Fix declaring repository on resource when it is a service entity repository #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
fix/di-on-service-entity-repositories
branch
from
cef6da0
to
a6c4c59
Compare
loic425
force-pushed
the
fix/di-on-service-entity-repositories
branch
from
a6c4c59
to
b0ddbd2
Compare
|
I'm wondering if we can go further, cause we can inject other dependencies into the repository. Maybe we should check if the FQCN is already registered and autowired. If we are in this case, we have nothing to do. |
lchrusciel
approved these changes
Dec 8, 2022
| @@ -68,7 +68,12 @@ protected function addRepository(ContainerBuilder $container, MetadataInterface | |||
|
|
|||
| $genericEntities[] = $entityClass; | |||
| } else { | |||
| $definition->setArguments([$managerReference, $this->getClassMetadataDefinition($metadata)]); | |||
| if (is_a($repositoryClass, ServiceEntityRepository::class, true)) { | |||
| $definition->setArguments([new Reference('doctrine')]); | |||
There was a problem hiding this comment.
Why did you decide on a new doctrine reference instead of new Reference($metadata->getServiceId('manager'));?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes this issue https://github.com/Sylius/SyliusResourceBundle/actions/runs/3575281362/jobs/6011624266#step:11:27