Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Flip id with alias on resource loader #701

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 13, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

That does not work for decoration anymore.

Here is an example which fails without this fix.

<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
           xsi:schemaLocation="http://symfony.com/schema/dic/services https://symfony.com/schema/dic/services/services-1.0.xsd">

    <services>
        <defaults public="true" />

        <service id="Mobizel\SyliusExportPlugin\Routing\ResourceLoader"
                 decorates="sylius.routing.loader.resource"
                 public="false"
        >
            <argument type="service" id="Mobizel\SyliusExportPlugin\Routing\ResourceLoader.inner"/>
            <argument type="service" id="sylius.resource_registry" />
            <argument type="service">
                <service class="Sylius\Bundle\ResourceBundle\Routing\RouteFactory" />
            </argument>
        </service>
    </services>
</container>

@loic425 loic425 requested a review from a team as a code owner April 13, 2023 13:50
@loic425 loic425 changed the title [HotFix] Flip id an alias on resource loader [HotFix] Flip id with alias on resource loader Apr 13, 2023
@loic425 loic425 changed the base branch from 1.11 to 1.10 April 13, 2023 14:28
@lchrusciel lchrusciel merged commit da093f5 into Sylius:1.10 Apr 17, 2023
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the hotfix-routing branch April 17, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants