Init validate provider #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
approved these changes
Nov 27, 2023
| } | ||
|
|
||
| /** @test */ | ||
| public function it_throws_an_exception_when_validating_resource_on_non_html_format(): void |
There was a problem hiding this comment.
it_validates_resource_with_validation_context_on_non_html_format
it_throws_an_exception_when_validating_resource_on_non_html_format
I wonder if methods names can or should be re-pharesed a bit.
My first thought is that difference in validation without exception and with exception is due "validation context" presence.
Though I don't have better idea
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #796