Remove Twig 2 support #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Sep 5, 2024
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
reviewed
Sep 5, 2024
| "vimeo/psalm": "^5.20", | ||
| "willdurand/hateoas-bundle": "^2.0" | ||
| }, | ||
| "conflict": { | ||
| "friendsofsymfony/rest-bundle": "<3.0", | ||
| "jms/serializer-bundle": "<3.5", | ||
| "willdurand/hateoas-bundle": "<2.0 || ^2.6" | ||
| "willdurand/hateoas-bundle": "<2.0 || ^2.6", | ||
| "twig/twig": "<3.0" |
There was a problem hiding this comment.
As we have bumped up the dependency, I'm not sure if it is necessary to add this package additionally to the conflicts (and the about note to the CONFLICTS file), do you see any benefit of that? 🤔
There was a problem hiding this comment.
cause it's on require-dev, it needs a conflict. We often forgot about those conflicts when there are on "optional/dev" requirements.
However, I do not know if adding note in the conflict make sense, cause it's just a bumped dependency.
There was a problem hiding this comment.
I've removed CONFLICTS file part.
loic425
force-pushed
the
maintenance/remove-twig-2-support
branch
from
857dcec
to
d0c0184
Compare
GSadee
approved these changes
Sep 6, 2024
|
Thank you, Loïc! 🎉 |
GSadee
added
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.