Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NES PPU Viewer's "zoom box" shouldn't be anti-aliased #3764

Open
YoshiRulz opened this issue Sep 1, 2023 · 3 comments
Open

NES PPU Viewer's "zoom box" shouldn't be anti-aliased #3764

YoshiRulz opened this issue Sep 1, 2023 · 3 comments
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements good first issue GitHub uses this label to recommend Issues re: Multiplatform Relating to the Linux and macOS ports (Mono Framework, and eventually .NET Core)

Comments

@YoshiRulz
Copy link
Member

This guy:

private System.Windows.Forms.PictureBox ZoomBox;

PictureBox doesn't accept an InterpolationMode though. This SO answer suggests subclassing it and overriding OnPaint to mutate the Graphics before calling the base method. Don't forget to set PixelOffsetMode = Half too if you go ahead with this.

@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend good first issue GitHub uses this label to recommend Issues labels Sep 1, 2023
@Morilli
Copy link
Collaborator

Morilli commented Jun 17, 2024

Is there a bug currently? From what I see, the graphics in that box are not antialised, so what is the suggestion here?

@YoshiRulz
Copy link
Member Author

YoshiRulz commented Jun 18, 2024

Still present at f309dbc. This may be Mono-specific, I recall @TalicZealot had a similar bug in their ext. tool on Linux only.
(Bonus bug: Window is too narrow and it can't be resized.)
screenshot

@Morilli
Copy link
Collaborator

Morilli commented Jun 18, 2024

This may be Mono-specific

Yep, looks that way. I found some old comments on InterpolationMode.NearestNeighbor being ignored, and it has something to do with Mono's libgdiplus using Cairo and that handles stuff differently... or something. In any case, this is most likely not related to anything BizHawk at all.

@YoshiRulz YoshiRulz added Enhancement For feature requests or possible improvements re: Multiplatform Relating to the Linux and macOS ports (Mono Framework, and eventually .NET Core) labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Enhancement For feature requests or possible improvements good first issue GitHub uses this label to recommend Issues re: Multiplatform Relating to the Linux and macOS ports (Mono Framework, and eventually .NET Core)
Projects
None yet
Development

No branches or pull requests

2 participants