Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with DSM movies parsing. Parser assumes run starts from savestate even though it doesn't #2006

Open
McBobX-1 opened this issue Oct 9, 2024 · 2 comments
Labels
bug Movie Parsers The movie parsers themselves

Comments

@McBobX-1
Copy link

McBobX-1 commented Oct 9, 2024

So I just submitted my DS TAS to the site couple minutes ago, and the submission says that it starts from savestate, which is not. Input file also indicates that it doesn't (savestate 0).
Link to submission: https://tasvideos.org/9336S

@CasualPokePlayer
Copy link
Collaborator

CasualPokePlayer commented Oct 9, 2024

The exact issue at least appears to be between 0.9.11 and 0.9.13 savestate anchored movies changed. The savestate key previously was meant for the actual savestate, embbed into the movie file (and so if the key is present, a savestate is present). With 0.9.13, the savestate is a separate file, and the savestate key is just for indicating if a savestate is present or not (so the key will be present regardless of whether a savestate is present or not). The site parser currently thus has the logic of assuming a savestate is present if the savestate header key is present.

@YoshiRulz YoshiRulz added bug Movie Parsers The movie parsers themselves labels Oct 9, 2024
@adelikat
Copy link
Collaborator

adelikat commented Oct 9, 2024

Wow! That's a terrible regression for the .dsm format, I'd recommend we not even accept savestate anchored movies after 9.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Movie Parsers The movie parsers themselves
Projects
None yet
Development

No branches or pull requests

4 participants