Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lowS: false flag to secp256k1.ts verify #714

Closed
Tracked by #806
theisens opened this issue Mar 26, 2024 · 3 comments · Fixed by #811
Closed
Tracked by #806

Add lowS: false flag to secp256k1.ts verify #714

theisens opened this issue Mar 26, 2024 · 3 comments · Fixed by #811
Assignees
@aniketh-varma
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest For the hacking month of October

Comments

@theisens
Copy link
Contributor

As has been noted in the @web5/crypto package, support for low-s signatures is not guaranteed by major KMS providers. I have personally run into this issue when using Azure keys for signing. Requesting that the lowS flag be set to false by default for verification of secp256k1 signatures, as it is in @web5/crypto package.
@OR13
Copy link

OR13 commented Mar 26, 2024

jfyi, if you are not sure which type of signature you are being handed, and you require lower s, you can always normalize to lower s before calling verify.

@thehenrytsai thehenrytsai added feature New feature or request good first issue Good for newcomers labels May 15, 2024
@thehenrytsai thehenrytsai added the hacktoberfest For the hacking month of October label Sep 13, 2024
@taniashiba taniashiba mentioned this issue Sep 23, 2024
Open
19 tasks
@aniketh-varma
Copy link
Contributor

.take

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Thanks for taking this issue! Let us know if you have any questions!

@aniketh-varma aniketh-varma mentioned this issue Oct 2, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aniketh-varma aniketh-varma

Labels
feature New feature or request good first issue Good for newcomers hacktoberfest For the hacking month of October
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setting lowS: false by default for verification of secp256k1 signatures aniketh-varma/dwn-sdk-js
4 participants
@OR13 @thehenrytsai @theisens @aniketh-varma