Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility creation and calibration improvements #87

Open
samaloney opened this issue Apr 14, 2024 · 2 comments
Open

Visibility creation and calibration improvements #87

samaloney opened this issue Apr 14, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@samaloney
Copy link
Member

  • Support other pixel combinations, currently only works with large pixels only, small pixels only, small and large, top bottom.
  • Check use of phase_center v centre make sure correct and keep same nomenclature as xrayvision
  • Don't have to overwrite u and v coordinates
@samaloney samaloney added the enhancement New feature or request label Apr 14, 2024
@samaloney samaloney added this to the v0.2.0 milestone Apr 14, 2024
@paolomassa
Copy link
Contributor

Check also units of the STIX visibilities

@paolomassa
Copy link
Contributor

Also, I think that the output of create_visibility and of calibrate_visibility should be a visibility structure. Maybe this is also related this issue in xrayvision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants