Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the on_cmd method of the extension have a return value #193

Open
halajohn opened this issue Oct 23, 2024 · 0 comments
Open

Can the on_cmd method of the extension have a return value #193

halajohn opened this issue Oct 23, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@halajohn
Copy link
Member

If we want to inherit the extension, can the on_cmd method of the extension have a return value? Otherwise, it will be difficult to handle in the parent class. The subclass can't determine whether the parent class has already processed the command, and if it hasn't, based on the current logic, there must be a return result as a fallback. Otherwise, the thread will get stuck.

We need to consider the meaning of the return value in the current situation where it's not in the base class/child class.

@halajohn halajohn added the enhancement New feature or request label Oct 23, 2024
@halajohn halajohn self-assigned this Oct 23, 2024
@halajohn halajohn assigned halajohn and unassigned halajohn Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant