Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After replacing all msgpack implementations with loop fields, the execution speed slowed down considerably #228

Open
halajohn opened this issue Nov 2, 2024 · 2 comments · May be fixed by #225
Assignees

Comments

@halajohn
Copy link
Member

halajohn commented Nov 2, 2024

No description provided.

@sunxilin
Copy link
Collaborator

sunxilin commented Nov 4, 2024

When I noticed the slowdown in performance, I did not conduct a proper control experiment. The slow execution at that time could have been due to the machine running other programs or other reasons. Later, I conducted a control experiment again, running 200 smoke tests, and the execution times for both were nearly the same.

@sunxilin
Copy link
Collaborator

sunxilin commented Nov 4, 2024

企业微信截图_0a773eef-e8a8-4908-bd73-dcfd489a12f3
Before replacing the implementation of msgpack, the total time taken to run the smoke tests was 55,979 ms.

企业微信截图_e03c432f-fc6f-4879-8f5f-aea4efeaeff7
After replacing the implementation of msgpack with loop, the total time taken was 55,925 ms.

@sunxilin sunxilin linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants