Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_bulk_actions() - inconsistent returns #182

Closed
tivnet opened this issue Mar 25, 2014 · 3 comments
Closed

process_bulk_actions() - inconsistent returns #182

tivnet opened this issue Mar 25, 2014 · 3 comments

Comments

@tivnet
Copy link
Contributor

tivnet commented Mar 25, 2014

Most returns are boolean. However, here is it is void:

                // Return early if there are no plugins to activate.
                if ( empty( $plugins_to_activate ) ) {
                    return;
                }

and it's void at the end of the function.
Should be always void or always bool, I think.

@thomasgriffin
Copy link
Contributor

I have made this consistent so that it returns boolean values. I have also added contextual messages to ensure that users know if they try to install/activate and there are no plugins that match the criteria, a message is displayed for them.

@tivnet
Copy link
Contributor Author

tivnet commented Mar 28, 2014

Is there a commit for this?

@thomasgriffin
Copy link
Contributor

Just pushed the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants