We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ℹ️ View this commit on Github 👥 Authored by Garvin Hicking [email protected] ✔️ Merged by Benni Mack [email protected]
[BUGFIX] Show number of total records found in EXT:indexed_search
With the refactorings in #102925 and #102945 the total number of search results was referred to in result.pagination.totalAmount.
result.pagination.totalAmount
However due to the Slice-pagination used, that variable will not contain the right contents and needs to be replaced with result.count.
result.count
This change adapts the default indexedsearch Search.html template and adjusts the Changelog entry.
Resolves: #104861 Related: #102925 Related: #102945 Releases: main, 13.4 Change-Id: Ia7d8d42d7884f776d996318c75c115722433f564 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86704 Reviewed-by: Benni Mack [email protected] Tested-by: Benni Mack [email protected] Tested-by: Mogens Fiebrandt [email protected] Reviewed-by: Mogens Fiebrandt [email protected] Tested-by: core-ci [email protected]
@@ -51,7 +51,7 @@ JavaScript via :html:`<f:asset.script>`: .. code-block:: html <f:sanitize.html> - <f:translate key="displayResults" arguments="{0: result.pagination.startRecordNumber, 1: result.pagination.endRecordNumber, 2: result.pagination.totalAmount}" /> + <f:translate key="displayResults" arguments="{0: result.pagination.startRecordNumber, 1: result.pagination.endRecordNumber, 2: result.count}" /> </f:sanitize.html> `is:pageBrowsing` has been replaced with a new Fluid partial file:
@@ -39,7 +39,7 @@ Migration .. code-block:: html <f:sanitize.html> - <f:translate key="displayResults" arguments="{0: result.pagination.startRecordNumber, 1: result.pagination.endRecordNumber, 2: result.pagination.totalAmount}" /> + <f:translate key="displayResults" arguments="{0: result.pagination.startRecordNumber, 1: result.pagination.endRecordNumber, 2: result.count}" /> </f:sanitize.html> `is:pageBrowsing` has been replaced with a new Fluid partial file:
The text was updated successfully, but these errors were encountered:
No branches or pull requests
ℹ️ View this commit on Github
👥 Authored by Garvin Hicking [email protected]
✔️ Merged by Benni Mack [email protected]
Commit message
[BUGFIX] Show number of total records found in EXT:indexed_search
With the refactorings in #102925 and #102945 the total number
of search results was referred to in
result.pagination.totalAmount
.However due to the Slice-pagination used, that variable will
not contain the right contents and needs to be replaced with
result.count
.This change adapts the default indexedsearch Search.html template
and adjusts the Changelog entry.
Resolves: #104861
Related: #102925
Related: #102945
Releases: main, 13.4
Change-Id: Ia7d8d42d7884f776d996318c75c115722433f564
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86704
Reviewed-by: Benni Mack [email protected]
Tested-by: Benni Mack [email protected]
Tested-by: Mogens Fiebrandt [email protected]
Reviewed-by: Mogens Fiebrandt [email protected]
Tested-by: core-ci [email protected]
➗ Modified files
13.0/Breaking-102925-TemplateChangesInIndexedSearch.rst
13.0/Breaking-102945-PaginationOfIndexedSearchReplaced.rst
The text was updated successfully, but these errors were encountered: