Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Selecting an item takes a long time #517

Open
3 tasks done
NeedNot opened this issue Sep 19, 2024 · 3 comments
Open
3 tasks done

[Bug]: Selecting an item takes a long time #517

NeedNot opened this issue Sep 19, 2024 · 3 comments
Labels
System: macOS For the macOS operating system Type: Bug Something isn't working as intended

Comments

@NeedNot
Copy link

NeedNot commented Sep 19, 2024

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha 9.4

Operating System & Version

MacOS 12.7.6

Description

When clicking on an item (selecting) it takes about a second or more to select the item, so the red selection indicator and the information on the right side lag behind significantly.

Expected Behavior

On my windows 11 Desktop which is a lot more powerful than my Macbook the selection is near instant

Steps to Reproduce

  1. Open a library
  2. Select an item
  3. Select a different item and notice the delay

Logs

No response

@NeedNot NeedNot added the Type: Bug Something isn't working as intended label Sep 19, 2024
@Snaperkids
Copy link

Can I ask what the specs of your Mac and windows systems are? Any information on which hardware is having issues can help narrow down the issue

@NeedNot
Copy link
Author

NeedNot commented Sep 19, 2024

Can I ask what the specs of your Mac and windows systems are? Any information on which hardware is having issues can help narrow down the issue

Screen Shot 2024-09-19 at 1 54 17 PM storage is an ssd

my windows computer:

Windows 11
Cpu: Ryzen 7 3700x
Gpu: Rtx 2080
Memory: 32gb 3200mhz
The library was located on an HDD

I've narrowed it down for spots that take a long to run

about 2s
https://github.com/TagStudioDev/TagStudio/blob/Alpha-v9.4/tagstudio/src/qt/widgets/preview_panel.py#L584-L598

also about 2s
https://github.com/TagStudioDev/TagStudio/blob/Alpha-v9.4/tagstudio/src/qt/widgets/preview_panel.py#L683-L690

as for why I said earlier it took about 1s well that was when I was using the latest released 9.4.1 which isn't detecting ffmpeg, running the python script directly ffmpeg is working

I'm switching over to my desktop so I can see why it's so much faster.

@NeedNot
Copy link
Author

NeedNot commented Sep 19, 2024

Ok update on my windows pc, I should specify that ffmpeg IS working it has the dialog saying it's not, and then mp4 thumbnails are not working which is another bug report, the jpg thumbnails are working it's just there are so few I didn't see them at first

did a test on
https://github.com/TagStudioDev/TagStudio/blob/Alpha-v9.4/tagstudio/src/qt/widgets/preview_panel.py#L584-L598
And for large images ~20 raws
it was taking 1-4s to show in the preview panel but a difference was that the selection was still instant

since they were images they weren't triggering the second block

edit: I think this just comes down to me looking at large images and videos, works fine with small images

@CyanVoxel CyanVoxel added the System: macOS For the macOS operating system label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
System: macOS For the macOS operating system Type: Bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants