Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha] [DEV] Resolve local windows issues #5662

Closed
incepter opened this issue Jul 3, 2023 · 1 comment · Fixed by #5664
Closed

[Alpha] [DEV] Resolve local windows issues #5662

incepter opened this issue Jul 3, 2023 · 1 comment · Fixed by #5664

Comments

@incepter
Copy link
Contributor

incepter commented Jul 3, 2023

Describe the bug

While working on the react query repo on my windows machine, many tests fail either on v4 and v5.

The goal of this issue is to gather all these unpredictable behavior and solve it for easier contribution.

  1. All codemods tests fail
  2. Random tests failure on the react-query and solid-query test:lib task

The following NX execution report shows these failing tests: https://cloud.nx.app/runs/xLS4cJgzUL

Your minimal, reproducible example

I tested on my win 11 machine

Steps to reproduce

  1. Clone the repo on a widonws machine
  2. cd root of the repo
  3. pnpm i -r
  4. pnpm test

Expected behavior

As a possible contributor, I would like to have the exact same behavior locally and on CI

How often does this bug happen?

Every time

Screenshots or Videos

https://cloud.nx.app/runs/xLS4cJgzUL

Platform

Windows 11
Node 16.18

Tanstack Query adapter

None

TanStack Query version

v5

TypeScript version

v5

Additional context

No response

@incepter
Copy link
Contributor Author

incepter commented Jul 3, 2023

#5664 Fixes the codemods tests

For the other tests, I will look into their failure cause later and see if there is another solution beside opting to "fake timers"

@TkDodo TkDodo closed this as completed Jul 14, 2023
@TkDodo TkDodo linked a pull request Jul 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants