Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page crash on bad date-time inputs #182

Open
adrmckinney opened this issue Sep 15, 2023 · 2 comments
Open

Page crash on bad date-time inputs #182

adrmckinney opened this issue Sep 15, 2023 · 2 comments

Comments

@adrmckinney
Copy link

Describe the bug
On the page where the mentor registers availabilities, if the end_time is before the start_time then there is a 400 error and the page goes blank.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://momentors.dev/profile'
  2. put in a start time
  3. put in an end time that is before the start time
  4. hit submit

Expected behavior
There should be validations in place to check if the start and end times are acceptable. If they are not then there should be a clear indication in the UI that the dates are incorrect and the submit button should be disabled. We should not even be able to make the api call to get that 400 error.

Screenshots
A blank screen is the end result

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
I'm not sure if there is already a validation system/library/architecture in place but it might be worth figuring that out before fixing this bug. If that is too big of a scope then never mind, it should just be fixed however someone wants to.

@GitLukeW
Copy link
Contributor

Thank you again for the call out @adrmckinney, just wanted to keep you posted that we have this on the board and hope to get to it soon!

@esparr
Copy link
Collaborator

esparr commented Nov 13, 2023

@adrmckinney @GitLukeW Thanks for keeping up with this issue. The backend validation issue has been fixed and we have a ticket for the front end validation here: https://github.com/orgs/TeamProductionSystem/projects/2/views/1?pane=issue&itemId=44507025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants