-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mergeObject, Object.keys error in IE11 #117
Comments
this problem is indirectly related to #54 |
It doesn't specifically check what you pass in, but it doesn't explicitly support other uses either. #54 is a discussion about whether or not undefined or null should be explicitly handled. |
I agree with you, but all major browsers correct resolve this problem, except IE11. So a lot of developers can send the wrong argument and don't catch any problem. We have different behavior for different browsers, it's not good. |
I can prepare PR if you this that validator it's a good idea. |
I'd rather not add type-checking assertions to this smallish codebase - beyond adding a few more lines of code, it would be a breaking change, since there could be codebases passing in strings or whatever as the first argument, and it could be fine for them as long as they're not shipping to IE11. I would rather focus on updating the typescript definition to be more correct/restrictive. |
TypeScript types are published with deepmerge as of 2.2.0. #119 |
Hello guys,
I found next bug. We have the next function:
I can send any value in
source
argument.When I send number, string, boolean in Google Chrome and even Edge returns empty array.
But IE11 - throw exception.
I think need to check type of
source
before useObject.keys
The text was updated successfully, but these errors were encountered: