Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

插件参数校验没有合理报错提示 #734

Closed
iccengan opened this issue Feb 21, 2020 · 1 comment
Closed

插件参数校验没有合理报错提示 #734

iccengan opened this issue Feb 21, 2020 · 1 comment
Assignees
@vhwweng
Labels
area/ci/frontend CI 前端特性issue done Production environment in tencent has been deploy for gray UAT environment in tencent has been deploy for test Test environment in tencent has been deploy grayed uat环境测试通过/test passed for uat stage kind/feat/product 产品特性 tested 测试环境通过/test patest passed for test stage
Milestone
v1.8

Comments

@iccengan
Copy link

iccengan commented Feb 21, 2020 •
edited
Loading

现象：

当插件名称字符过长时，插件标红。保存流水线时提示“请输入正确的流水线”。用户无法通过报错得知插件出了什么问题。
image
image

期望：

  1. 插件名称输入框添加30个字符的限制，超过后不允许继续输入
  2. 报错提示文案优化为：插件名称过长，不能超过30个字符
@irwinsun irwinsun added the help wanted Extra attention is needed label Feb 24, 2020
@github-actions
Copy link

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@iccengan iccengan added kind/feat/product 产品特性 and removed no-issue-activity labels Jun 1, 2020
@iccengan iccengan added the area/ci/frontend CI 前端特性issue label Jul 28, 2020
@irwinsun irwinsun removed the help wanted Extra attention is needed label Dec 4, 2020
@iccengan iccengan added this to the v1.6 milestone May 24, 2021
@irwinsun irwinsun modified the milestones: v1.6, v1.7 Jun 9, 2021
@zanyzhao zanyzhao modified the milestones: v1.7, v1.8 Aug 4, 2021
@lockiechen lockiechen removed their assignment Aug 5, 2021
@iccengan iccengan modified the milestones: v1.7, Backlog Oct 27, 2021
@irwinsun irwinsun changed the title 插件名称过长时，没有合理报错提示 插件参数校验没有合理报错提示 Jan 26, 2022
@iccengan iccengan assigned vhwweng and unassigned zhanxu33 Jan 26, 2022
@iccengan iccengan modified the milestones: Backlog, v1.8 Jan 26, 2022
@vhwweng vhwweng mentioned this issue Jan 26, 2022
Merged
lockiechen added a commit that referenced this issue Feb 10, 2022
@lockiechen
Merge pull request #6094 from vhwweng/issue_734
aebb2e9 
feat: 插件名字长度限制30个字符 #734
@lockiechen lockiechen added the for test Test environment in tencent has been deploy label Feb 10, 2022
@bkci-bot bkci-bot added the for gray UAT environment in tencent has been deploy label Feb 10, 2022
@lockiechen lockiechen added the tested 测试环境通过/test patest passed for test stage label Feb 10, 2022
@iccengan iccengan added the grayed uat环境测试通过/test passed for uat stage label Feb 17, 2022
@bkci-bot bkci-bot added the done Production environment in tencent has been deploy label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vhwweng vhwweng

Labels
area/ci/frontend CI 前端特性issue done Production environment in tencent has been deploy for gray UAT environment in tencent has been deploy for test Test environment in tencent has been deploy grayed uat环境测试通过/test passed for uat stage kind/feat/product 产品特性 tested 测试环境通过/test patest passed for test stage
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
7 participants
@zanyzhao @iccengan @irwinsun @zhanxu33 @lockiechen @bkci-bot @vhwweng