Fix -Werror=free-nonheap-object warning as error and add support for RVCT 4.1 ARM compiler #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the perftest, schematest.cpp was yielding an error in relation to freeing a stack object. This change fixes that by explicitly passing in nullptr to CrtAllocator::Free if we don't own the memory. Change-Id: Ide53cc324af1ae3fef3d9096684e3aac0c1427ff
|
is also safe and does not invoke undefined behavior as per the standard. |
|
@miloyip, @tencent-adm, this patch should be ready to go |
This change adds the necessary preprocessor checks to support the RVCT 4.1 ARM compiler. Change-Id: I9b516af326aef08aaafda00a5f89b125d39b1f04
|
Added another commit to the PR to support the RVCT 4.1 ARM compiler with some preprocessor checks |
djbn65
changed the title
|
@miloyip, @tencent-adm, this is ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the perftest, schematest.cpp was yielding an error in relation to freeing a stack object. This change fixes that by explicitly passing in nullptr to CrtAllocator::Free if we don't own the memory.
Fixes: #2267