-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 重构 Slider 组件 #115
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
28bef16
chore: cache
LeeJim 9ca872c
fix(slider): update
LeeJim 2e7057e
fix(slider): update demo
LeeJim b674c74
fix(slider): resolve marks currectly
LeeJim b453431
test: update snapshots
LeeJim 2d712cb
fix(slider): optimize
LeeJim f959d4a
test: resolve exec errors
LeeJim e42fd35
build: resolve errors
LeeJim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,7 +64,6 @@ | |
.slider-demo { | ||
background-color: #fff; | ||
padding: 12px 16px; | ||
max-height: 69px; | ||
} | ||
|
||
.stepper-demo { | ||
|
Submodule _common
updated
13 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { ref, Ref, getCurrentInstance, ComponentInternalInstance } from 'vue'; | ||
|
||
export type ChangeHandler = (value: any, ...args: any[]) => void; | ||
|
||
export default function useVModel<T>( | ||
value: Ref<T>, | ||
modelValue: Ref<T>, | ||
defaultValue: T, | ||
onChange?: ChangeHandler, | ||
propName = 'value', | ||
// emit 和 eventName 用于支持 v-model 和 xxx.sync 语法糖 | ||
): [Ref<T>, ChangeHandler] { | ||
const { emit } = getCurrentInstance() as ComponentInternalInstance; | ||
const internalValue = ref<T>() as Ref<T>; | ||
internalValue.value = defaultValue; | ||
|
||
// 受控模式 v-model:propName | ||
if (typeof value.value !== 'undefined') { | ||
return [ | ||
value, | ||
(newValue, ...args) => { | ||
emit?.(`update:${propName}`, newValue, ...args); | ||
onChange?.(newValue, ...args); | ||
}, | ||
]; | ||
} | ||
|
||
// 受控模式:modelValue v-model | ||
if (typeof modelValue.value !== 'undefined') { | ||
return [ | ||
modelValue, | ||
(newValue, ...args) => { | ||
emit?.(`update:modelValue`, newValue, ...args); | ||
onChange?.(newValue, ...args); | ||
}, | ||
]; | ||
} | ||
|
||
// 非受控模式 | ||
return [ | ||
internalValue, | ||
(newValue, ...args) => { | ||
internalValue.value = newValue; | ||
onChange?.(newValue, ...args); | ||
}, | ||
]; | ||
} | ||
|
||
// emits name | ||
export const UPDATE_MODEL = 'update:modelValue'; | ||
export const UPDATE_VALUE = 'update:value'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,9 @@ | ||
<template> | ||
<div class="cell-base"> | ||
<t-cell-group title="基础滑动选择器"> | ||
<t-cell label="选择器标题"> | ||
<t-slider v-model="value" @change="onChange"> </t-slider> | ||
</t-cell> | ||
<t-cell label="禁用选择器"> | ||
<t-slider v-model="value" disabled> </t-slider> | ||
</t-cell> | ||
</t-cell-group> | ||
</div> | ||
<t-slider v-model="value" /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { ref, defineComponent } from 'vue'; | ||
<script lang="ts" setup> | ||
import { ref } from 'vue'; | ||
|
||
export default defineComponent({ | ||
setup() { | ||
const value = ref(60); | ||
function onChange($event: number | number[]) { | ||
console.log(`change to ${$event}`); | ||
} | ||
return { | ||
value, | ||
onChange, | ||
}; | ||
}, | ||
}); | ||
const value = ref(60); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<template> | ||
<div class="section"> | ||
<t-slider :default-value="60" disabled /> | ||
</div> | ||
<div class="section"> | ||
<t-slider :default-value="30" show-extreme-value :min="30" disabled /> | ||
</div> | ||
<div class="section"> | ||
<t-slider :default-value="50" :marks="marks" disabled /> | ||
</div> | ||
<div class="section"> | ||
<t-slider :default-value="[30, 80]" range disabled /> | ||
</div> | ||
</template> | ||
|
||
<script lang="ts" setup> | ||
import { ref } from 'vue'; | ||
|
||
const marks = ref({ 0: '小', 50: '中', 100: '大' }); | ||
</script> | ||
|
||
<style lang="less" scoped> | ||
.section { | ||
// display: flex; | ||
align-items: center; | ||
padding-top: 16px; | ||
padding-bottom: 16px; | ||
|
||
& + .section { | ||
margin-top: 16px; | ||
} | ||
} | ||
</style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,27 +1,16 @@ | ||
<template> | ||
<div class="cell-base"> | ||
<t-cell-group title="带刻度滑动选择器"> | ||
<t-cell label="选择器标题"> | ||
<t-slider v-model="value" :marks="marks"> </t-slider> | ||
</t-cell> | ||
<t-cell label="禁用选择器"> | ||
<t-slider v-model="value" disabled :marks="marks"> </t-slider> | ||
</t-cell> | ||
</t-cell-group> | ||
</div> | ||
<t-slider v-model="value" :marks="marks" /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { ref, defineComponent } from 'vue'; | ||
<script lang="ts" setup> | ||
import { ref } from 'vue'; | ||
|
||
export default defineComponent({ | ||
setup() { | ||
const value = ref(50); | ||
const marks = ref({ 0: '小', 50: '中', 100: '大' }); | ||
return { | ||
value, | ||
marks, | ||
}; | ||
}, | ||
}); | ||
const value = ref(50); | ||
const marks = ref({ 0: '小', 50: '中', 100: '大' }); | ||
// const marks = ref([0, 50, 100]); | ||
// const marks = ref({ | ||
// 0: (val: number) => `${val}%`, | ||
// 50: (val: number) => `${val}%`, | ||
// 100: (val: number) => `${val}%`, | ||
// }); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,13 @@ | ||
<template> | ||
<div class="cell-base"> | ||
<t-cell-group title="区间滑动选择器"> | ||
<t-cell label="选择器标题"> | ||
<t-slider v-model="rangeValue" show-value range @change="onChange"> </t-slider> | ||
</t-cell> | ||
<t-cell label="禁用选择器"> | ||
<t-slider v-model="rangeValue" range disabled> </t-slider> | ||
</t-cell> | ||
</t-cell-group> | ||
</div> | ||
<t-slider v-model="rangeValue" show-value range @change="onChange" /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { ref, defineComponent } from 'vue'; | ||
<script lang="ts" setup> | ||
import { ref } from 'vue'; | ||
|
||
export default defineComponent({ | ||
setup() { | ||
const rangeValue = ref([30, 80]); | ||
function onChange($event: number | number[]) { | ||
console.log(`change to ${$event}`); | ||
} | ||
return { | ||
rangeValue, | ||
onChange, | ||
}; | ||
}, | ||
}); | ||
const rangeValue = ref([30, 80]); | ||
|
||
function onChange($event: number | number[]) { | ||
console.log(`change to ${$event}`); | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,9 @@ | ||
<template> | ||
<div class="cell-base"> | ||
<t-cell-group title="带数字滑动选择器"> | ||
<t-cell label="选择器标题"> | ||
<t-slider v-model="value" show-value> </t-slider> | ||
</t-cell> | ||
<t-cell label="禁用选择器"> | ||
<t-slider v-model="value" disabled show-value> </t-slider> | ||
</t-cell> | ||
</t-cell-group> | ||
</div> | ||
<t-slider v-model="value" show-value /> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { ref, defineComponent } from 'vue'; | ||
<script lang="ts" setup> | ||
import { ref } from 'vue'; | ||
|
||
export default defineComponent({ | ||
setup() { | ||
const value = ref(60); | ||
return { | ||
value, | ||
}; | ||
}, | ||
}); | ||
const value = ref(60); | ||
</script> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经有了useVModel这个hook,在src/shared/useVModel