Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/dialog #564

Merged
merged 16 commits into from
Apr 18, 2023
Merged

Refactor/dialog #564

merged 16 commits into from
Apr 18, 2023

Conversation

tangzixuan
Copy link
Contributor

@tangzixuan tangzixuan commented Apr 5, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Dialog): 新增 closeBtn 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 6, 2023

  1. dom结构对齐小程序,v2样式理论上可以直接复用,不用在大量修改
  2. 示例对齐小程序端,目前示例有缺
  3. .gitmodules 不用提交

.gitmodules Outdated Show resolved Hide resolved
@anlyyao anlyyao mentioned this pull request Apr 14, 2023
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 14, 2023

多按钮下 button默认样式还有点问题 辛苦在跟进一波~
截屏2023-04-14 19 13 44

src/dialog/dialog.vue Outdated Show resolved Hide resolved
src/dialog/demos/confirm.vue Outdated Show resolved Hide resolved
src/dialog/demos/feedback.vue Outdated Show resolved Hide resolved
src/dialog/demos/image-dialog.vue Outdated Show resolved Hide resolved
src/dialog/demos/input.vue Outdated Show resolved Hide resolved
src/dialog/demos/multi-state.vue Outdated Show resolved Hide resolved
@anlyyao anlyyao merged commit fcf9254 into Tencent:refactor/dialog Apr 18, 2023
anlyyao pushed a commit that referenced this pull request Apr 18, 2023
* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1
anlyyao pushed a commit that referenced this pull request Apr 21, 2023
* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1
LeeJim pushed a commit that referenced this pull request Apr 24, 2023
* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1

* feat: 1
LeeJim added a commit that referenced this pull request Apr 24, 2023
* refactor(Dialog): update api

* Refactor/dialog (#564)

* fix: remove useless css

* fix: resolve conflict

* refactor(dialog): finish

* chore: update common

* fix: resolve ts problem

* test: update

---------

Co-authored-by: jerimizhang <[email protected]>
Co-authored-by: leejimqiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants