-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rate): rate tips #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
交互上有几个bug:
- tips偶尔会不消失
- 半选的情况下,tips里有一个star会慢一点出现
src/rate/demos/base.vue
Outdated
@@ -1,6 +1,6 @@ | |||
<template> | |||
<CustomCell title="请点击评分"> | |||
<t-rate v-model="value" clearable :gap="defaultGap" @change="changeValue" /> | |||
<CustomCell title="实心评分"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉CustomCell后,样式是单独都写在每个示例里面吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的。
<FilledDemo /> | ||
<br /> | ||
<tdesign-demo-block title="01 组件类型" summary="实心评分"> | ||
<BaseDemo /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/rate/rate.vue
Outdated
import { ref, computed, defineComponent, ExtractPropTypes, PropType, ComputedRef } from 'vue'; | ||
import { StarFilledIcon, StarIcon } from 'tdesign-icons-vue-next'; | ||
import { ref, computed, defineComponent } from 'vue'; | ||
import { IconFont } from 'tdesign-icons-vue-next'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样会引入全量的图标,直接引入star即可
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在不是改成传icon name了吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要和小程序不一样。
提交的分支也不对,需要合并进 develop |
🤔 这个 PR 的性质是?
🔗 相关 Issue
移动端 mobile-vue 发布正式版 #514
💡 需求背景和解决方案
📝 更新日志
refactor(rate): rate增加tips
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单