Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): add destroy-on-close property #672

Merged
merged 2 commits into from
May 17, 2023

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented May 16, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Popup): 新增 destroyOnClose 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@LeeJim LeeJim changed the title fix(popup): add destroy-on-hide property fix(popup): add destroy-on-close property May 16, 2023
@github-actions
Copy link
Contributor

Size Change: +220 B (0%)

Total Size: 446 kB

Filename Size Change
./dist/tdesign.js 267 kB +133 B (0%)
./dist/tdesign.min.js 127 kB +87 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 30 kB
./dist/tdesign.min.css 21.9 kB

@github-actions
Copy link
Contributor

完成

@LeeJim LeeJim merged commit aafa4c1 into develop May 17, 2023
@LeeJim LeeJim deleted the feat/popup/add-destroy-on-hide branch May 17, 2023 07:09
LeeJim added a commit that referenced this pull request May 17, 2023
* feat(drawer): add new version

* Refactor/rate (#642)

* feat(Rate): update api

* refactor(rate): rate tips

* refactor(rate): rate tips

* refactor(rate): rate tips

* refactor(rate): rate

rate tips

* chore: update _common

* test: update snapshots

* fix(Rate): gap value is changed to 8

---------

Co-authored-by: anlyyao <[email protected]>

* fix(popup): add destroy-on-close property (#672)

* fix(popup): add destroy-on-hide property

* fix(popup): finish destroy-on-close

* feat(drawer): add new version

* fix(drawer): resolve ts error

* test(drawer): update snapshot

* test: update snapshot

* test: update snapshot

---------

Co-authored-by: chunqi feng <[email protected]>
Co-authored-by: anlyyao <[email protected]>
@github-actions github-actions bot mentioned this pull request May 23, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant