Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] add hostname of affected machine to subject of email notification and remove spare "Alert" #137

Open
dahorak opened this issue Oct 31, 2017 · 8 comments
Assignees

Comments

@dahorak
Copy link

dahorak commented Oct 31, 2017

It might be useful to add also hostname of affected machine into subject of email notification.

It will help with orientation in the email flow. For example from the following screenshot it is not immediately clear, if there is only one problematic server or more.

email_notification_subjects

Also the second Alert word is unnecessary and I think it might be omitted.

Actual form:
Subject: [Tendrl Alert] Memory Alert, WARNING: threshold breached

Expected form:
Subject: [Tendrl Alert] Memory, WARNING: threshold breached - gluster1.example.com

@GowthamShanmugam
Copy link
Collaborator

GowthamShanmugam commented Nov 2, 2017

@dahorak what about cluster related alert, cluster name is big right, is this good to add cluster name in mail subject for cluster-related alerts?

because we don't have a meaningful cluster name, and it is very big also.

@shtripat ^

@dahorak
Copy link
Author

dahorak commented Nov 2, 2017

@GowthamShanmugam I agree, that Gluster "name" is not much meaningful and is quite long.
Maybe it might make sense to use only some part of the name - similarly what git do with commit hash - the hash is long, but on most places, it shows/uses only first few (on github 7) characters.

@GowthamShanmugam
Copy link
Collaborator

having partial cluster name is not going to help much, what I feel is better we keep the only hostname in the subject only for node related alerts.

Because in UI also filtering is happening only by integration id, cluster also lister in UI only using integration id,
Inside alert message also we are having only integration id.
so maintaining cluster name in a subject not going to help I feel.

one more problem is brick related alerts are common for node and cluster, so here confusion occurs like which name I have to give in subject

@shtripat @nthomas-redhat @r0h4n @nnDarshan

@shtripat
Copy link
Member

shtripat commented Nov 2, 2017

@GowthamShanmugam I feel this generalization issue is because the subject line of notification is formed inside notifier module. I would suggest if possible get the same done within handler, as we have more control over what data to be put in the subject line.

@Tendrl/tendrl-core comments ?

@r0h4n
Copy link
Contributor

r0h4n commented Nov 9, 2017

@brainfunked Can you please comment on this

@GowthamShanmugam
Copy link
Collaborator

@Tendrl/tendrl-core

@brainfunked
Copy link
Contributor

How about a format such as: [Tendrl] <PRIORITY>: <alert message> [<Component>] (<HOST/CLUSTER>: <id>)? This would lead to examples such as:

  • [Tendrl] INFO: Threshold breach [Memory] (HOST: <fqdn>)
  • [Tendrl] WARNING: Threshold breach [Volume Capacity] (CLUSTER: <cluster id>)

The use of brackets and terms in a specific pattern would also make the subject lines machine parsable, which may prove to be useful in some cases.

@r0h4n r0h4n added this to the Milestone 3 (2018) milestone Feb 17, 2018
@r0h4n
Copy link
Contributor

r0h4n commented Apr 20, 2018

@GowthamShanmugam updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants