Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtle failure in UNDO #500

Open
1 task
Terkwood opened this issue May 13, 2021 · 5 comments
Open
1 task

Subtle failure in UNDO #500

Terkwood opened this issue May 13, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@Terkwood
Copy link
Owner

Terkwood commented May 13, 2021

she went back 7 moves and then tried to go forward and it blocked up

Generally undo works, but sometimes it doesn't.

Is this about backend? If so, which service? Does sync impact this?

Or is it the frontend?

Can we describe the failure scenario more precisely? Sometimes after 60 undos you still cannot trigger this bug

@Terkwood Terkwood added the bug Something isn't working label May 13, 2021
@Terkwood Terkwood pinned this issue May 13, 2021
@Terkwood
Copy link
Owner Author

Terkwood commented May 15, 2021

We should create an integration testing app which can communicate with Redis and push undo commands, expect move undone events, push make move commands, expect acceptance. It should push many thousands of requests and detect failure. This would either rule out or blame the undo /changelog flow

@Terkwood

This comment has been minimized.

@Terkwood

This comment has been minimized.

@Terkwood Terkwood unpinned this issue Jun 24, 2021
@Terkwood
Copy link
Owner Author

This occurs infrequently when I test using personal devices. Can it be triggered more often if BUGOUT web client is running on an azure vm ?

@Terkwood
Copy link
Owner Author

This failure state does not prevent unrelated games from proceeding. It does not log anything useful in undo service.

one potential plan

Write sync procedures into sync service and browser impl,so that silently failing UNDO requests can be reconciled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant