Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is .gitignore respected? #98

Closed
nodesocket opened this issue Mar 27, 2023 · 11 comments
Closed

Is .gitignore respected? #98

nodesocket opened this issue Mar 27, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@nodesocket
Copy link

Does this respect .gitignore to prevent sending secrets, passwords, api keys to 3rd parties? Thanks.

@TerminalFi
Copy link
Owner

By default..no it does not. Is that a feature in the VSCode implementation?

You can likely achieve this by removing the text from the selector setting.


"selector": "source | text | embedding"

If this is a feature that the VSCode version supports. Let me know, I'd like to support it.

@nodesocket
Copy link
Author

nodesocket commented Mar 28, 2023

@TerminalFi that's a great question. Some very trivial testing I did in a project with a .gitignore in VSCode with CoPilot enabled seems to indicate changes in files which are in the .gitignore are being suggested by CoPilot. So, that's very concerning.

I opened a discussion on the official GitHub CoPilot community if you want to follow along and maybe upvote? https://github.com/orgs/community/discussions/51183

@TerminalFi
Copy link
Owner

Sure, also I think that is a reasonable request and perhaps we can support it via our plug-in as an interim. Will look into it.

@TerminalFi
Copy link
Owner

@jfcherng @timfjord Thoughts on this feature being supported?

2023-05-04_20-43-29.mp4

@TerminalFi
Copy link
Owner

@nodesocket Would this type of implementation meet your expectations?

Essentially LSP-copilot is still enabled in this file. However it respects the .gitignore and updates the status bar. So the Language server still knows you are working in a supported file type but since it is in the .gitignore it will NOT send requests to Copilot

@TerminalFi
Copy link
Owner

I fixed the flashing on the statusbar

@jfcherng
Copy link
Collaborator

jfcherng commented May 9, 2023

Related to #106

@neverbot
Copy link

I think the Copilot people are working in a .copilotignore specification. Using VS Studio - Insiders it gives the file a specific icon, and Copilot Chat seems to think the file is already working.

I posted it in the github community discussions.

240266558-bc57d00e-b00e-4dc4-bfce-4b10acca8849

Screenshot 2023-05-23 at 13 55 41

@TerminalFi
Copy link
Owner

Awesome, so perhaps I can close the MR and wait

@TerminalFi
Copy link
Owner

#169

@TerminalFi
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants