Fix sass 1.79 deprecation warnings #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also an annoying: that would presumably be resolved by bumping sass-loader to v16, but that requires TerriaJS/TerriaMap to drop the support for the EOL'd Node 16. |
|
Thanks for this @pjonsson could you please add a line to |
pjonsson
force-pushed
the
fix-sass-deprecation-warnings
branch
2 times, most recently
from
b87281c
to
4732e68
Compare
This bumps sass to version 1.79 and fixes the deprecation warning: DEPRECATION WARNING: lighten() is deprecated. Suggestions: color.scale($color, $lightness: 21.7021276596%) color.adjust($color, $lightness: 10%) More info: https://sass-lang.com/d/color-functions ╷ 12 │ @return lighten($base-color, 10%); │ ^^^^^^^^^^^^^^^^^^^^^^^^^ ╵ lib/Sass/common/_variables.scss 12:11 get-hover-color() lib/Sass/common/_buttons.scss 69:17 root stylesheet and: DEPRECATION WARNING: darken() is deprecated. Suggestions: color.scale($color, $lightness: -27.7551020408%) color.adjust($color, $lightness: -8%) More info: https://sass-lang.com/d/color-functions ╷ 172 │ $chart-darker: darken($dark, 8%); │ ^^^^^^^^^^^^^^^^^ ╵ lib/Sass/common/_variables.scss 172:16 @import lib/Sass/common/_buttons.scss 1:9 root stylesheet
pjonsson
force-pushed
the
fix-sass-deprecation-warnings
branch
from
4732e68
to
2ca0e0a
Compare
|
@ljowen fixed. |
ljowen
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This bumps sass to version 1.79 and fixes
the deprecation warning:
DEPRECATION WARNING: lighten() is deprecated. Suggestions: color.scale($color, $lightness: 21.7021276596%)
color.adjust($color, $lightness: 10%)
More info: https://sass-lang.com/d/color-functions
╷
12 │ @return lighten($base-color, 10%);
│ ^^^^^^^^^^^^^^^^^^^^^^^^^
╵
lib/Sass/common/_variables.scss 12:11 get-hover-color()
lib/Sass/common/_buttons.scss 69:17 root stylesheet
and:
DEPRECATION WARNING: darken() is deprecated. Suggestions: color.scale($color, $lightness: -27.7551020408%)
color.adjust($color, $lightness: -8%)
More info: https://sass-lang.com/d/color-functions
╷
172 │ $chart-darker: darken($dark, 8%);
│ ^^^^^^^^^^^^^^^^^
╵
lib/Sass/common/_variables.scss 172:16 @import
lib/Sass/common/_buttons.scss 1:9 root stylesheet
Test me
Check that darkened and lightened colors appear as they should.
Checklist
doc/.