From 65e005cffe69cbf11a1c42aaca1c5add4739faf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodrigo=20Gir=C3=A3o=20Serr=C3=A3o?= <5621605+rodrigogiraoserrao@users.noreply.github.com> Date: Thu, 23 Mar 2023 10:07:33 +0000 Subject: [PATCH] Return 'self' explicitly. Related review comment: https://github.com/Textualize/textual/pull/2102\#pullrequestreview-1354201387 --- src/textual/widgets/_data_table.py | 18 ++++++++++++------ src/textual/widgets/_text_log.py | 3 ++- src/textual/widgets/_tree.py | 3 ++- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/src/textual/widgets/_data_table.py b/src/textual/widgets/_data_table.py index 50c8814ce5..4469f85a3a 100644 --- a/src/textual/widgets/_data_table.py +++ b/src/textual/widgets/_data_table.py @@ -1178,7 +1178,8 @@ def clear(self, columns: bool = False) -> Self: self.hover_coordinate = Coordinate(0, 0) self._label_column = Column(self._label_column_key, Text(), auto_width=True) self._labelled_row_exists = False - return self.refresh() + self.refresh() + return self def add_column( self, label: TextType, *, width: int | None = None, key: str | None = None @@ -1348,7 +1349,8 @@ def refresh_coordinate(self, coordinate: Coordinate) -> Self: if not self.is_valid_coordinate(coordinate): return self region = self._get_cell_region(coordinate) - return self._refresh_region(region) + self._refresh_region(region) + return self def refresh_row(self, row_index: int) -> Self: """Refresh the row at the given index. @@ -1363,7 +1365,8 @@ def refresh_row(self, row_index: int) -> Self: return self region = self._get_row_region(row_index) - return self._refresh_region(region) + self._refresh_region(region) + return self def refresh_column(self, column_index: int) -> Self: """Refresh the column at the given index. @@ -1378,7 +1381,8 @@ def refresh_column(self, column_index: int) -> Self: return self region = self._get_column_region(column_index) - return self._refresh_region(region) + self._refresh_region(region) + return self def _refresh_region(self, region: Region) -> Self: """Refresh a region of the DataTable, if it's visible within the window. @@ -1391,7 +1395,8 @@ def _refresh_region(self, region: Region) -> Self: if not self.window_region.overlaps(region): return self region = region.translate(-self.scroll_offset) - return self.refresh(region) + self.refresh(region) + return self def is_valid_row_index(self, row_index: int) -> bool: """Return a boolean indicating whether the row_index is within table bounds. @@ -1880,7 +1885,8 @@ def sort_by_column_keys( {key: new_index for new_index, (key, _) in enumerate(ordered_rows)} ) self._update_count += 1 - return self.refresh() + self.refresh() + return self def _scroll_cursor_into_view(self, animate: bool = False) -> None: """When the cursor is at a boundary of the DataTable and moves out diff --git a/src/textual/widgets/_text_log.py b/src/textual/widgets/_text_log.py index 4fba9f24a2..bcf0923546 100644 --- a/src/textual/widgets/_text_log.py +++ b/src/textual/widgets/_text_log.py @@ -173,7 +173,8 @@ def clear(self) -> Self: self._start_line = 0 self.max_width = 0 self.virtual_size = Size(self.max_width, len(self.lines)) - return self.refresh() + self.refresh() + return self def render_line(self, y: int) -> Strip: scroll_x, scroll_y = self.scroll_offset diff --git a/src/textual/widgets/_tree.py b/src/textual/widgets/_tree.py index e5da2166b7..db0d77cf7a 100644 --- a/src/textual/widgets/_tree.py +++ b/src/textual/widgets/_tree.py @@ -647,7 +647,8 @@ def clear(self) -> Self: expanded=True, ) self._updates += 1 - return self.refresh() + self.refresh() + return self def reset(self, label: TextType, data: TreeDataType | None = None) -> Self: """Clear the tree and reset the root node.