Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BUTTON_INNER based on value #2310

Closed
bphunter1972 opened this issue Apr 17, 2023 · 0 comments
Closed

Change BUTTON_INNER based on value #2310

bphunter1972 opened this issue Apr 17, 2023 · 0 comments

Comments

@bphunter1972
Copy link

From #1934, wouldn't this make a whole lot more sense in _toggle_button.py?

BUTTON_INNER: dict[bool, str] = {True: "X", False: " "}

I thought that checkboxes were simply broken, but instead it was that the bold attribute simply doesn't stand out enough at smaller fonts.

Then of course in _button():

        return Text.assemble(
            (self.BUTTON_LEFT, side_style),
            (self.BUTTON_INNER[self.value], button_style),
            (self.BUTTON_RIGHT, side_style),
        )
@Textualize Textualize deleted a comment from github-actions bot Apr 18, 2023
@Textualize Textualize locked and limited conversation to collaborators Apr 18, 2023
@davep davep converted this issue into discussion #2312 Apr 18, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant