Confusing ValueError: No Tab with id 'tab-1' when a NoMatches is expected

[barisione]

Querying a non existing ID in an app using TabbedCotent causes a confusing error:

from textual import containers, widgets
from textual.app import App, ComposeResult


class MyApp(App):
    def compose(self) -> ComposeResult:
        with containers.Vertical():
            with widgets.TabbedContent():
                with widgets.TabPane("List #1"):
                    yield widgets.ListView(id="foo")

    def on_ready(self) -> None:
        self.query_one(f"#bar")  # Note the wrong ID.


MyApp().run()

This gives me ValueError: No Tab with id 'tab-1'. If you scroll up you can see NoMatches: No nodes match but it's confusing and sort of hidden.

Textual Diagnostics

Versions

Name	Value
Textual	0.23.0
Rich	13.3.5

Python

Name	Value
Version	3.10.1
Implementation	CPython
Compiler	Clang 13.0.0 (clang-1300.0.29.30)
Executable	/Users/bari/.pyenv/versions/3.10.1/envs/undo-core-venv3.10/bin/python3.10

Operating System

Name	Value
System	Darwin
Release	21.6.0
Version	Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64

Terminal

Name	Value
Terminal Application	iTerm.app (3.5.0beta10)
TERM	xterm-256color
COLORTERM	truecolor
FORCE_COLOR	Not set
NO_COLOR	Not set

Rich Console options

Name	Value
size	width=238, height=62
legacy_windows	False
min_width	1
max_width	238
is_terminal	True
encoding	utf-8
max_height	62
justify	None
overflow	None
no_wrap	False
highlight	None
markup	None
height	None

[github-actions]

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

[TomJGooding]

Sorry, just totally ignore my previous PR!

If you comment out the container, this returns the NoMatches error as expected. Not really sure why yet, but posting in case it helps someone smarter to debug this!

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.