Calling pop_screen multiple times causes a flickering effect

[mzebrak]

Consider the example below. When calling pop_screen multiple times (which is not so unusual - because a "form" structure where we can go through subsequent screens can work in such a way that it dumps all screens after approval), flickering occurs.

import random
from typing import Callable

from textual.app import App, ComposeResult
from textual.binding import Binding
from textual.color import Color
from textual.containers import Container
from textual.screen import Screen
from textual.widgets import Footer, Header


class SomeScreen(Screen):
    def compose(self) -> ComposeResult:
        yield Header()

        element = Container()
        element.styles.background = self._get_random_color()
        yield element

        yield Footer()

    @staticmethod
    def _get_random_color() -> Color:
        def rand() -> int:
            return random.randint(0, 255)
        return Color(rand(), rand(), rand())


class MyApp(App[None]):
    BINDINGS = [
        Binding("p", "pop", "Pop multiple screens"),
    ]

    def on_mount(self) -> None:
        self.push_screen(SomeScreen(id="first"))
        for _ in range(50):
            self.push_screen(SomeScreen())

    def action_pop(self) -> None:
        self.pop_screen_until(lambda screen: screen.id == "first")

    def pop_screen_until(self, condition_callback: Callable[[Screen], bool]) -> None:
        while not condition_callback(self.screen):
            self.pop_screen()


if __name__ == "__main__":
    MyApp().run()

What I tried is with self.batch_update() context manager but it seems it does not work in this context.
Maybe it's possible to extend the batch_update method to apply it on screen-related actions also or create a new method like batch_screen_update?

[github-actions]

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.