Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltips stop appearing when a widget is maximized #5083

Closed
ByTheSeaL opened this issue Oct 3, 2024 · 5 comments · Fixed by #5088
Closed

tooltips stop appearing when a widget is maximized #5083

ByTheSeaL opened this issue Oct 3, 2024 · 5 comments · Fixed by #5088

Comments

@ByTheSeaL
Copy link

Before I maximize any widget tooltips work fine within the Header of my app:

Screenshot 2024-10-03 130021

And within my main Datatable (these are assigned dynamically by watching the Datatable's 'hover_coordinate'):

Screenshot 2024-10-03 130033

I have a link which maximizes the Container that contains the Datatable ("ALLOW_MAXIMIZE" is set on the link's Label and on the Container), and I make the app's header appear in maximized view still by setting:

self.app.screen.ALLOW_IN_MAXIMIZED_VIEW = "MyHeader"

When I'm in maximized view the tooltips just stop appearing:

Screenshot 2024-10-03 130451
Screenshot 2024-10-03 130459

(if it's useful I can see that the watch method watching hover_coordinate is still being triggered in maximized view. There's no interruption in other events - for eg changing the value in an Input still works etc)

Copy link

github-actions bot commented Oct 3, 2024

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@willmcgugan
Copy link
Collaborator

Add .textual-system to your ALLOW_IN_MAXIMIZED_VIEW. i.e. self.app.screen.ALLOW_IN_MAXIMIZED_VIEW = ".textual-system,MyHeader"

@willmcgugan
Copy link
Collaborator

willmcgugan commented Oct 3, 2024

There will be an update in the next version, so this won't be necessary in the future.

@ByTheSeaL
Copy link
Author

Ah great.
There was one hyphen missing from the ALLOW_IN_MAXIMIZED_VIEW addition but worked out via a search of the source that it was ".-textual-system" so all OK. All working now. Thanks @willmcgugan

Copy link

github-actions bot commented Oct 4, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants