Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening videos with right click (youtube) #51

Open
Chaostheorie opened this issue Apr 7, 2021 · 0 comments · May be fixed by #52
Open

Opening videos with right click (youtube) #51

Chaostheorie opened this issue Apr 7, 2021 · 0 comments · May be fixed by #52

Comments

@Chaostheorie
Copy link

Steps to reproduce:

  • Starting the server for play-with-mpv
  • Open a video on YouTube (e.g. A Cat Video)
  • Right-Click on the running video twice (since YouTube has its own context menu)
  • Click play-with-mpv

Expected Behavior:

Video would be opened.

Observed Behavior:

Video is successfully sent to internal play-with-mpv server but doesn't play due to error (see below):

[...]
[file] Cannot open file 'blob:https://www.youtube.com/80d576ea-46a7-4123-8fd1-79200e4ff32f': No such file or directory
Failed to open blob:https://www.youtube.com/80d576ea-46a7-4123-8fd1-79200e4ff32f.

Fix:

The right click menu needs to remove the blob: prefix. At the moment only the menu in the top right corner works since it sends the URL directly.

Environment:

  • Browser: Brave Browser 89.1.22.71
  • Python: Python 3.7.3
  • Extension: 0.1.0
  • play-with-mpv: from git
@Chaostheorie Chaostheorie linked a pull request Apr 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant