-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type regression between v0.31.2 and v0.40.1 #403
Type regression between v0.31.2 and v0.40.1 #403
Comments
There are other differences between the two versions:
// v0.40.1
export type Options = {
hashLength?: number | undefined;
timeCost?: number | undefined;
memoryCost?: number | undefined;
parallelism?: number | undefined;
type?: 0 | 2 | 1 | undefined;
version?: number | undefined;
salt?: any;
associatedData?: any;
secret?: any;
};
// v0.31.2
export interface Options {
hashLength?: number;
timeCost?: number;
memoryCost?: number;
parallelism?: number;
type?: typeof argon2d | typeof argon2i | typeof argon2id;
version?: number;
salt?: Buffer;
saltLength?: number;
raw?: boolean;
secret?: Buffer;
associatedData?: Buffer;
} |
No one has said anything?. They just changed the parameters without changing the doc? |
The parameter was not changed, there is a bug in Typescript when generating object types from JSDoc that I still didn't figure out how to fix, since it works as expected on my machine, in an isolated container |
I just republished and Typescript is still generating incorrect types. |
This remains an issue and is blocking us from upgrading from 0.31.2 to the latest version. Tested with 0.40.3 Is there anything we can do to help with this? |
Welcome to the issues section if it's your first time!
Before creating an issue, please be sure to:
Steps to reproduce
Expected behaviour
The “saltLength” field must be present in the
Options
type, as it was in version 0.31.2 (see theargon2.d.ts
file).Actual behaviour
The “saltLength” field is not present in the Options type, see the
argon2.d.cts
file in version 0.40.1.The text was updated successfully, but these errors were encountered: