Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AWS credential retrieval failure nicely #35

Closed
haoliangyu opened this issue Jul 15, 2017 · 2 comments
Closed

Handle AWS credential retrieval failure nicely #35

haoliangyu opened this issue Jul 15, 2017 · 2 comments

Comments

@haoliangyu
Copy link

haoliangyu commented Jul 15, 2017

Currently there is no error handling for the function getAWSCredentials(). If it fails to retrieve the AWS credential, it will simply print the following message in the console.

(node:17597) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): 
TypeError: Data must be a string or a buffer
(node:17597) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the 
future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit 
code.

It doesn't throw an error with a complete failure stacktrace and stop the program from running further even though the ES initialization completely fails. Because of this failure, if the user continue to use ES, he will always get a time-out error.

@TheDeveloper
Copy link
Owner

Hi, thanks for the report and the details.

Agreed, should be handling this better.

@haoliangyu haoliangyu changed the title Handle AWS credential retreival failure nicely Handle AWS credential retrieval failure nicely Jul 15, 2017
@pradyumna1
Copy link

This isn't fixed yet I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants