Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generated version header contains invalid code if the target name isn't a valid macro identifier #37

Closed
jan-moeller opened this issue Nov 6, 2023 · 0 comments · Fixed by #38

Comments

@jan-moeller
Copy link
Contributor

For example, for a cmake target "super-lib", the generated macros are SUPER-LIB_VERSION*, which is not a valid preprocessor macro name. One can of course rename the target, but I do believe that dashes in target names are fairly common, so it would be nice if PackageProject supported this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant