-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure CircleCI tests get run for PR's from forks #477
Comments
@Asartea Thanks, shared with the team. |
poke |
@01zulfi Do you need help with this? |
@CouchofTomato Yeah, I don't think I have access to TOP's CircleCI. Looking back at Discord chats, CircleCI workflows should trigger from forks, but I guess that's not the case with #556 @KevinMulhern can you see what's up Discord chat: https://discord.com/channels/505093832157691914/817034720881672233/1210869220645015573 |
I did check circle CI and it is setup for being triggered from forks so it's a weird one. Hopefully Kevin can get to the bottom of it. |
Weirdly enough, in #556 it did run after the second commit. Testing... |
And in #561 it immediately ran a test. Going to blame it on "Vague weirdness" Oh wait I see: CircleCI has now picked it up under my account, not under TOP's |
@Asartea just double checking that this issue can be closed? |
I don't think has actually been fixed? Its fixed for the specific case of 'Asartea submits a PR', but that's because I have my own account on CircleCi, so its running tests under my account |
Complete the following REQUIRED checkboxes:
I have thoroughly read and understand The Odin Project Contributing Guide
The title of this issue follows the
command name: brief description of request
format, e.g./help: add optional @user parameter
The following checkbox is OPTIONAL:
1. Description of the Feature Request:
Yesterday a broken change got into the bot's main branch (I had forgotten to push a snapshot update), which caused it to not update to new versions of commands. CircleCI caught this, but it only ran once the change landed on the
main
branch, at which point it was already in. It should have also run when I proposed the PR, so that it can be caught before it gets merged2. Acceptance Criteria:
3. Additional Information:
The text was updated successfully, but these errors were encountered: