Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update app to Rails 7 #3049

Closed
6 of 9 tasks
ChargrilledChook opened this issue Jul 2, 2022 · 5 comments · Fixed by #3608
Closed
6 of 9 tasks

Chore: Update app to Rails 7 #3049

ChargrilledChook opened this issue Jul 2, 2022 · 5 comments · Fixed by #3608
Labels
dependencies Pull requests that update a dependency file Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.

Comments

@ChargrilledChook
Copy link
Member

ChargrilledChook commented Jul 2, 2022

Given we're now teaching Rails 7 it would be good to have parity with the app too.

Official upgrade guide

Todo

Notes

  • Now Chore: Begin Rails 7 upgrade #3608 is merged the app is running on Rails 7, but there is still some follow up work to do.
  • Devise incompatibility may no longer be an issue
@ChargrilledChook
Copy link
Member Author

There's a somewhat vague instruction in the upgrade guide

"Change the versions for Rails JavaScript packages in package.json and run yarn install, if running on Webpacker."

But no obvious info on where to find relevant versions. It is probably worth removing UJS, though

@KevinMulhern
Copy link
Member

Thanks for getting this started @ChargrilledChook 💪

Should we break some chores out of this?

  • Chore for fixing the oauth2 depreciation
  • Maybe another for getting Hotwire in the app with turbo turned off.
  • Another for replacing any Rails ujs behaviour we use.
    etc

@ChargrilledChook
Copy link
Member Author

ChargrilledChook commented Jul 3, 2022

Thanks for getting this started @ChargrilledChook muscle

My pleasure 🔧

Should we break some chores out of this?

Great idea, I'll spin up a few issues out of this and keep track of them in this one

@ChargrilledChook ChargrilledChook linked a pull request Jul 3, 2022 that will close this issue
@ChargrilledChook ChargrilledChook added dependencies Pull requests that update a dependency file Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc. labels Jul 9, 2022
@ChargrilledChook ChargrilledChook changed the title Upgrade: Update app to Rails 7 Chore: Update app to Rails 7 Jul 23, 2022
@ChargrilledChook ChargrilledChook linked a pull request Jan 22, 2023 that will close this issue
@ChargrilledChook
Copy link
Member Author

Updated OP now #3608 is merged with some follow up work to do

@ChargrilledChook
Copy link
Member Author

Outside of enabling Turbo, the app is now completely on Rails 7. I've opened a new story for the Turbo changes #3806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Chore Involves changes with no user-facing value, to the build process/internal tooling, refactors, etc.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants