Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for maps for multiple marker points #1241

Open
mjamescompton opened this issue Aug 26, 2019 · 1 comment
Open

Expand support for maps for multiple marker points #1241

mjamescompton opened this issue Aug 26, 2019 · 1 comment
Assignees
Labels
c/console This is related to the Console

Comments

@mjamescompton
Copy link
Contributor

Summary

Continuing the work from issue #235 and pr #1129 expanding the support for maps to include multiple markers, and to calculate its own center based on multiple marker points.

Why do we need this?

We want to be able to show all devices on a map on the application overview page.

What is already there? What do you see now?

An array of markers are feed to the map component as a prop and a functions 'getMapCenter' is run based if the marker array length is >= 1. Currently this function just return the first marker location.

What is missing? What do you want to see?

'getMapCenter' should return the center latitude, longitude and an appropriate zoom level for the map that includes all the marker points.

Environment

console

How do you propose to implement this?

Update React component function.

Can you do this yourself and submit a Pull Request?

yes

@mjamescompton mjamescompton added the c/console This is related to the Console label Aug 26, 2019
@mjamescompton mjamescompton added this to the Next Up milestone Aug 26, 2019
@mjamescompton mjamescompton self-assigned this Aug 26, 2019
@johanstokking johanstokking changed the title Expand Support for Maps for multiple marker points. Expand support for maps for multiple marker points Nov 12, 2019
@johanstokking
Copy link
Member

I have to see the real world deployment where the gateway antennas as so far out that we need to show them as different markers.

@johanstokking johanstokking modified the milestones: Next Up, Backlog Nov 12, 2019
@htdvisser htdvisser removed this from the Backlog milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console
Projects
None yet
Development

No branches or pull requests

3 participants