Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS SDK support for devices #131

Closed
kschiffer opened this issue Feb 12, 2019 · 0 comments
Closed

JS SDK support for devices #131

kschiffer opened this issue Feb 12, 2019 · 0 comments
Assignees
Labels
c/sdk/js This is related to the JavaScript SDK in progress We're working on it needs/discussion We need to discuss this
Milestone

Comments

@kschiffer
Copy link
Contributor

kschiffer commented Feb 12, 2019

Summary:
To provide console support for devices (#25), we first need to add support to the JS SDK. Due to the device structure being quite complex, it makes sense to discuss this matter explicitly.

Why do we need this?

  • To be able to provide devices CRUD support in the console
  • To support devices in the JS SDK (JavaScript SDK #30)

What is already there? What do you see now?

What is missing? What do you want to see?

  • A (sustainable) strategy for mapping paths to their respective component (NS, IS, JS, AS)

How do you propose to implement this?
Since I see no viable way to get this information automatically, my impulse would be to write a JSON definition that maps the devices fields to the respective component. It would look like this:

{
  "name": "is",
  "description": "is",
  …
  "min_frequency": "as",
  …
  "root_keys": "js"
}

The SDK would then use this definition to decide which component to ask for which path.
Pros:

  • Simple and declarative
  • Easy to implement

Cons:

  • We would need to keep this up to date (by generating this automatically from the protos)

At some later point, when we also generate API code for the SDK, we should also look into providing an automated solution to this issue as well.

What can you do yourself and what do you need help with?
If there is no objection to the strategy explained above, I will start implementing this.

cc @bafonins @htdvisser @johanstokking

@kschiffer kschiffer added c/console This is related to the Console needs/discussion We need to discuss this in progress We're working on it labels Feb 12, 2019
@kschiffer kschiffer added this to the February 2019 milestone Feb 12, 2019
@johanstokking johanstokking mentioned this issue Feb 12, 2019
30 tasks
@kschiffer kschiffer self-assigned this Feb 12, 2019
@kschiffer kschiffer modified the milestones: February 2019, March 2019 Feb 26, 2019
@kschiffer kschiffer added c/sdk/js This is related to the JavaScript SDK and removed c/console This is related to the Console labels Mar 5, 2019
@kschiffer kschiffer mentioned this issue Mar 28, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/sdk/js This is related to the JavaScript SDK in progress We're working on it needs/discussion We need to discuss this
Projects
None yet
Development

No branches or pull requests

1 participant