Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC to NS for generating ABP DevAddr #294

Closed
htdvisser opened this issue Mar 18, 2019 · 2 comments · Fixed by #758
Closed

Add RPC to NS for generating ABP DevAddr #294

htdvisser opened this issue Mar 18, 2019 · 2 comments · Fixed by #758
Assignees
Labels
c/network server This is related to the Network Server compat/api This could affect API compatibility size/small This should not be a lot of work
Milestone

Comments

@htdvisser
Copy link
Contributor

Summary:

We should add an RPC to the NS that generates a DevAddr for ABP devices.

Refs #47 (comment), probably also related to #130.

Why do we need this?

Clients such as the CLI and Console need to request a DevAddr from the NS in order to register ABP devices with a properly peering-routable DevAddr (so not one from the experimental range).

What is already there? What do you see now?

The CLI and Console generate DevAddrs for ABP devices from the experimental range. This works fine on private networks, but won't work over peering.

The NS generates DevAddrs from a NetID (or prefix after #130).

What is missing? What do you want to see?

The NS should have functionality to allocate DevAddrs for ABP devices and expose this over an RPC.

How do you propose to implement this?

Basically the same as what it does for OTAA devices, and then exposed as an RPC. Inputs of the generator are ctx, NetID/DevAddrPrefix of the NS, AppID and perhaps (in the future) an approximate location (so that we can later make the DevAddr allocation and matching smarter/faster). It returns a DevAddr.

What can you do yourself and what do you need help with?

I can assist with the API definition and other discussion.

@htdvisser htdvisser added c/network server This is related to the Network Server compat/api This could affect API compatibility labels Mar 18, 2019
@htdvisser htdvisser added this to the Backlog milestone Mar 18, 2019
@johanstokking johanstokking modified the milestones: Backlog, Next Up Mar 18, 2019
@johanstokking johanstokking added the size/small This should not be a lot of work label Apr 4, 2019
@htdvisser
Copy link
Contributor Author

@rvolosatovs proposed alternative of generating a DevAddr if unset

@htdvisser htdvisser modified the milestones: Next Up, May 2019 Apr 23, 2019
@htdvisser
Copy link
Contributor Author

htdvisser commented Apr 23, 2019

@johanstokking says that it should be possible to bring your own DevAddr, it should validate with the list of DevAddr prefixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server compat/api This could affect API compatibility size/small This should not be a lot of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants