Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linking references from the Console #3542

Closed
adriansmares opened this issue Nov 27, 2020 · 0 comments · Fixed by #3614
Closed

Remove linking references from the Console #3542

adriansmares opened this issue Nov 27, 2020 · 0 comments · Fixed by #3614
Assignees
Labels
c/console This is related to the Console in progress We're working on it
Milestone

Comments

@adriansmares
Copy link
Contributor

Summary

References #3263

We should remove any linking references from the Console in the 3.11 branch.

Why do we need this?

Linking has been completely removed as of #3263, both from the AS and from the NS. Fundamentally the only thing that is still part of the ttnpb.ApplicationLink is the default payload formatter and the application-wide skip-payload-encryption option, but any linking options such as NS address or API key are now gone.

What is already there? What do you see now?

  1. Automatic link creation on application creation.
  2. Application link status page

What is missing? What do you want to see?

Both should be removed.

Environment

3.11

How do you propose to implement this?

I suppose it's just deleting the forms / logic. One thing to look into is if updates to the application payload formatter still work (not sure if they are currently dependent on the existence of the link ?)

Can you do this yourself and submit a Pull Request?

I can review this.

@adriansmares adriansmares added the c/console This is related to the Console label Nov 27, 2020
@adriansmares adriansmares added this to the December 2020 milestone Nov 27, 2020
@asmulko asmulko assigned asmulko and unassigned kschiffer Dec 22, 2020
@asmulko asmulko added the in progress We're working on it label Dec 22, 2020
@asmulko asmulko mentioned this issue Dec 23, 2020
5 tasks
@asmulko asmulko linked a pull request Dec 29, 2020 that will close this issue
5 tasks
@asmulko asmulko closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console in progress We're working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants