Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Settings view for Devices #584

Closed
kschiffer opened this issue Apr 29, 2019 · 2 comments · Fixed by #624
Closed

General Settings view for Devices #584

kschiffer opened this issue Apr 29, 2019 · 2 comments · Fixed by #624
Assignees
Labels
c/console This is related to the Console
Milestone

Comments

@kschiffer
Copy link
Member

kschiffer commented Apr 29, 2019

Summary:
The console needs to allow users to change general data of a device, similar to how we allow it for applications already.

Why do we need this?
It's a basic feature.

What is already there? What do you see now?

What is missing? What do you want to see?

  • Info on what data can be edited after device creation (cc @htdvisser)
  • A way to delete devices
  • We don't need wireframes or screen design here

Environment:
Console in browser.

How do you propose to implement this?
Basically, use the add device form and strip a couple of fields.

Can you do this yourself and submit a Pull Request?
Yes.

@kschiffer kschiffer added the c/console This is related to the Console label Apr 29, 2019
@kschiffer kschiffer added this to the May 2019 milestone Apr 29, 2019
@kschiffer kschiffer self-assigned this Apr 29, 2019
@htdvisser
Copy link
Contributor

Question: Will we have a "view single device" screen or is that the same as the "update" screen (possibly with the inputs as read-only)?

For the update screen I think we should start by extending the create screen from #573. The main difference is that you can not change the ID or EUIs.

After this we should decide what additional fields we should add to both create and update, and what fields we only want to show in update.

Things that will become useful after users create their first device:

  • formatters (payload formatters)
  • mac_settings (all optional)

@kschiffer
Copy link
Member Author

Question: Will we have a "view single device" screen or is that the same as the "update" screen (possibly with the inputs as read-only)?

There is a single device overview screen (⟶ screen design, implemented via #376) which shows the most important info about the device. To update basic (simple key-value) information of the device, we use the "General Settings" tab. More complex data, such as payload formatters or (later on) device location will be set in dedicated views.

For the update screen I think we should start by extending the create screen from #573. The main difference is that you can not change the ID or EUIs.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants