Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some desired MAC parameters to MAC settings with opinionated defaults #60

Closed
johanstokking opened this issue Jan 29, 2019 · 1 comment
Assignees
Labels
c/network server This is related to the Network Server compat/api This could affect API compatibility in progress We're working on it
Milestone

Comments

@johanstokking
Copy link
Member

Summary:

Add some desired MAC parameters to the end device's MAC settings with opinionated defaults.

Why do we need this?

  1. For users to configure custom desired MAC parameters for each end device. This may be based on what's configured in the device repository
  2. To fall back to sane defaults that we have identified based on progressive insight running LoRaWAN public and private networks

What is already there? What do you see now?

We currently allow a few MAC settings, like use_adr, adr_margin, class_b_timeout, etc.

What is missing? What do you want to see?

We need to support at least the following settings:

  • rx1_delay; defaults to 5 seconds
  • rx2_data_rate_index; defaults to what is in the frequency plan
  • rx2_frequency; defaults to what is in the frequency plan

How do you propose to implement this?

The above fields to be added to the MACSettings, and set as desired parameters on device reset.

Note that the current parameters stay the band defaults, per spec. This means that we stay compliant with devices that have not received desired parameters yet (i.e. ABP devices).


Original issue: https://github.com/TheThingsIndustries/lorawan-stack/issues/1544 by @johanstokking

@johanstokking johanstokking added compat/api This could affect API compatibility c/network server This is related to the Network Server l/open source labels Jan 29, 2019
@johanstokking johanstokking added this to the February 2019 milestone Feb 4, 2019
@rvolosatovs
Copy link
Contributor

@johanstokking johanstokking added the blocked This can't continue until another issue or pull request is done label Feb 5, 2019
@rvolosatovs rvolosatovs removed the blocked This can't continue until another issue or pull request is done label Feb 6, 2019
@htdvisser htdvisser added the in progress We're working on it label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server compat/api This could affect API compatibility in progress We're working on it
Projects
None yet
Development

No branches or pull requests

3 participants