Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RN 0.69.4 and use_framework! #2812

Closed
billnbell opened this issue Aug 9, 2022 · 8 comments
Closed

Support for RN 0.69.4 and use_framework! #2812

billnbell opened this issue Aug 9, 2022 · 8 comments

Comments

@billnbell
Copy link

I am getting static issues with using use_framework! with this library.

What is the solution when using use_frameworks! ?

I am using: "react-native-video": "6.0.0-alpha.1"

I tried setting it to static and dynamic and still having errors compiling.

Thoughts?

@matinzd
Copy link

matinzd commented Aug 9, 2022

Are you using react-native-firebase? Maybe you can keep your react-native-firebase on v14.x.x since most libraries out there are not compatible with use_frameworks! especially Flipper and it seems this library as well.

@rafamanzo
Copy link

rafamanzo commented Aug 9, 2022

I'm using use_framework! with the 6.0.0-alpha.1. More specifically: use_frameworks! :linkage => :static. My app builds on iOS and the videos are working despite some workarounds I had to apply (#2808 and #2809).

What may be the difference that makes it work for me is the RN version. I'm still on 0.68.2

Edit: I also had to disable Flipper.

@billnbell
Copy link
Author

OK if you were to set static on the dependent pod specs for react-native-video what are those names?

@billnbell
Copy link
Author

Are you using react-native-firebase? Maybe you can keep your react-native-firebase on v14.x.x since most libraries out there are not compatible with use_frameworks! especially Flipper and it seems this library as well.

I love that idea. And agree.

@siliconsocket
Copy link

CocoaPods 1.5.0 introduced use_modular_headers! [details] to still provide module support with static libraries.

So for version with video caching:

pod 'DVAssetLoaderDelegate', :modular_headers => true
pod 'SPTPersistentCache', :modular_headers => true
pod 'react-native-video/VideoCaching', :path => '../node_modules/react-native-video/react-native-video.podspec'

with this config you don't need to add use_frameworks!,

tested with RN v0.69.3

@billnbell
Copy link
Author

@matinzd
Copy link

matinzd commented Sep 12, 2022

See invertase/react-native-firebase#6332

Thanks for the update!

@freeboub
Copy link
Collaborator

I am able to build with use_frameworks!, On 0.64 version of react native. No activity on this issue since long time. Let's close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants