Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progressUpdateInterval Not Working #521

Closed
flybayer opened this issue Mar 5, 2017 · 6 comments · Fixed by #800
Closed

progressUpdateInterval Not Working #521

flybayer opened this issue Mar 5, 2017 · 6 comments · Fixed by #800

Comments

@flybayer
Copy link

flybayer commented Mar 5, 2017

I'm trying to do this:

<Video
  source={{uri: this.props.uri}}
  repeat
  resizeMode="cover"
  progressUpdateInterval={16}
  onProgress={play => this.setState({
    playProgress: play.currentTime / play.playableDuration
  })}
/>

But onProgress is still being called on the default 250ms interval.

I added some logging in this component and found setSource() is being called before setProgressUpdateInterval(), so setSource() is always using the default.

I couldn't figure out how to fix it :(

Versions

iPhone 7+
react-native-video: 1.0.0
react-native: 0.42.0
@maltz
Copy link

maltz commented Jun 14, 2017

+1

@maltz
Copy link

maltz commented Jun 14, 2017

I fiexd ract-native-video/ios/RCTVideo.m line63

// _progressUpdateInterval = 250;
_progressUpdateInterval = 500;

It works.

@skizzo
Copy link

skizzo commented Aug 1, 2017

+1

1 similar comment
@Sundin
Copy link

Sundin commented Aug 16, 2017

+1

@ArtisanalPickle
Copy link

+1 please address this

@ouabing
Copy link

ouabing commented Jan 2, 2018

+1 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants