From 0b85cfc7d4ca663ef8caaaa374e446028896bfa6 Mon Sep 17 00:00:00 2001 From: Unknown Date: Mon, 21 Jan 2019 08:45:43 +0100 Subject: [PATCH 1/3] internal some APIs --- src/Akkatecture/Events/AggregateEventUpcaster.cs | 3 +-- src/Akkatecture/Events/DomainEventMapper.cs | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Akkatecture/Events/AggregateEventUpcaster.cs b/src/Akkatecture/Events/AggregateEventUpcaster.cs index 8bd2157f..1c737e4a 100644 --- a/src/Akkatecture/Events/AggregateEventUpcaster.cs +++ b/src/Akkatecture/Events/AggregateEventUpcaster.cs @@ -24,7 +24,6 @@ public abstract class AggregateEventUpcaster DecisionCache = new ConcurrentDictionary(); - public readonly IReadOnlyDictionary> UpcastFunctions; @@ -44,7 +43,7 @@ public AggregateEventUpcaster() } - public bool ShouldUpcast(object potentialUpcast) + private bool ShouldUpcast(object potentialUpcast) { var type = potentialUpcast.GetType(); diff --git a/src/Akkatecture/Events/DomainEventMapper.cs b/src/Akkatecture/Events/DomainEventMapper.cs index e97900a6..dfc74789 100644 --- a/src/Akkatecture/Events/DomainEventMapper.cs +++ b/src/Akkatecture/Events/DomainEventMapper.cs @@ -7,7 +7,7 @@ namespace Akkatecture.Events { public static class DomainEventMapper { - public static object FromComittedEvent(object evt) + internal static object FromComittedEvent(object evt) { var type = typeof(ICommittedEvent<,,>); @@ -16,8 +16,7 @@ public static object FromComittedEvent(object evt) //dynamic dispach here to get AggregateEvent var comittedEvent = evt as dynamic; - var typeInfo = evt.GetType().GetTypeInfo(); - + var genericType = typeof(DomainEvent<,,>) .MakeGenericType(type.GetGenericArguments()[0], type.GetGenericArguments()[1],type.GetGenericArguments()[2]); From bf51d24874fc6d65c4041089be7f65ab93581545 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" Date: Tue, 22 Jan 2019 04:22:50 +0000 Subject: [PATCH 2/3] Bump Microsoft.SourceLink.GitHub Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.0.0-beta-63127-02 to 1.0.0-beta2-18618-05. - [Release notes](https://github.com/dotnet/sourcelink/releases) - [Commits](https://github.com/dotnet/sourcelink/commits) Signed-off-by: dependabot[bot] --- src/Akkatecture/Akkatecture.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Akkatecture/Akkatecture.csproj b/src/Akkatecture/Akkatecture.csproj index 9c6fdc47..d2225974 100644 --- a/src/Akkatecture/Akkatecture.csproj +++ b/src/Akkatecture/Akkatecture.csproj @@ -29,7 +29,7 @@ - + From 76ebcf9110d7eeeebac40a799ad3e97b667f1bfd Mon Sep 17 00:00:00 2001 From: Unknown Date: Tue, 22 Jan 2019 08:28:41 +0100 Subject: [PATCH 3/3] slight cleanups --- .travis.yml | 10 ---------- .../Akkatecture.Walkthrough.Application/Program.cs | 1 - .../Aggregates/Resource/Events/ResourceCreatedEvent.cs | 4 ---- .../Domain/Sagas/ResourceCreationSagaState.cs | 1 - examples/web/Akkatecture.Examples.Api/Startup.cs | 1 - .../Aggregates/TestAggregateState.cs | 1 - 6 files changed, 18 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index f874d147..00000000 --- a/.travis.yml +++ /dev/null @@ -1,10 +0,0 @@ -language: csharp -mono: none -dotnet: 2.0.0 - -install: -- dotnet restore - -script: - - dotnet build - - dotnet test test/Akkatecture.Tests/Akkatecture.Tests.csproj \ No newline at end of file diff --git a/examples/walkthrough/Akkatecture.Walkthrough.Application/Program.cs b/examples/walkthrough/Akkatecture.Walkthrough.Application/Program.cs index 432ef2ef..bb1f2e87 100644 --- a/examples/walkthrough/Akkatecture.Walkthrough.Application/Program.cs +++ b/examples/walkthrough/Akkatecture.Walkthrough.Application/Program.cs @@ -32,7 +32,6 @@ using Akkatecture.Walkthrough.Domain.Repositories.Revenue.Queries; using Akkatecture.Walkthrough.Domain.Repositories.Revenue.ReadModels; using Akkatecture.Walkthrough.Domain.Sagas.MoneyTransfer; -using Akkatecture.Walkthrough.Domain.Subscribers; using Akkatecture.Walkthrough.Domain.Subscribers.Revenue; namespace Akkatecture.Walkthrough.Application diff --git a/examples/web/Akkatecture.Examples.Api/Domain/Aggregates/Resource/Events/ResourceCreatedEvent.cs b/examples/web/Akkatecture.Examples.Api/Domain/Aggregates/Resource/Events/ResourceCreatedEvent.cs index 7889c541..1fec6965 100644 --- a/examples/web/Akkatecture.Examples.Api/Domain/Aggregates/Resource/Events/ResourceCreatedEvent.cs +++ b/examples/web/Akkatecture.Examples.Api/Domain/Aggregates/Resource/Events/ResourceCreatedEvent.cs @@ -29,9 +29,5 @@ namespace Akkatecture.Examples.Api.Domain.Aggregates.Resource.Events [EventVersion("ResourceCreated", 1)] public class ResourceCreatedEvent : AggregateEvent { - public ResourceCreatedEvent() - { - - } } } \ No newline at end of file diff --git a/examples/web/Akkatecture.Examples.Api/Domain/Sagas/ResourceCreationSagaState.cs b/examples/web/Akkatecture.Examples.Api/Domain/Sagas/ResourceCreationSagaState.cs index 70caffb1..8a036567 100644 --- a/examples/web/Akkatecture.Examples.Api/Domain/Sagas/ResourceCreationSagaState.cs +++ b/examples/web/Akkatecture.Examples.Api/Domain/Sagas/ResourceCreationSagaState.cs @@ -22,7 +22,6 @@ // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. using Akkatecture.Aggregates; -using Akkatecture.Examples.Api.Domain.Aggregates.Resource.Events; using Akkatecture.Examples.Api.Domain.Sagas.Events; using Akkatecture.Sagas; diff --git a/examples/web/Akkatecture.Examples.Api/Startup.cs b/examples/web/Akkatecture.Examples.Api/Startup.cs index fb43dc02..7ebc535b 100644 --- a/examples/web/Akkatecture.Examples.Api/Startup.cs +++ b/examples/web/Akkatecture.Examples.Api/Startup.cs @@ -27,7 +27,6 @@ using Akkatecture.Examples.Api.Domain.Repositories.Resources; using Akkatecture.Examples.Api.Domain.Sagas; using Microsoft.AspNetCore.Builder; -using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; diff --git a/test/Akkatecture.TestHelpers/Aggregates/TestAggregateState.cs b/test/Akkatecture.TestHelpers/Aggregates/TestAggregateState.cs index 73c4622a..f938d3bd 100644 --- a/test/Akkatecture.TestHelpers/Aggregates/TestAggregateState.cs +++ b/test/Akkatecture.TestHelpers/Aggregates/TestAggregateState.cs @@ -21,7 +21,6 @@ // IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. -using System; using System.Collections.Generic; using System.Linq; using Akkatecture.Aggregates;