You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Having looked at this project (and really liking it), I noticed that the datetimeoffset type is used when representing the time passed since the Unix epoch.
As someone who is pretty fanatical about correct time representation and testing, I wondered whether you would consider switching to Nodatime. This would give you a type (Instant) that represents the time in UTC and therefore devoid of any timezone information as well as a clock representation that can be either mocked or have a fake representation injected that allows the manipulation of time during tests.
If this would be something you'd consider, I'm happy to put a proof of concept/PR together.
Thanks for the good work, it is really a time saver.
Sean.
The text was updated successfully, but these errors were encountered:
Hi,
Having looked at this project (and really liking it), I noticed that the datetimeoffset type is used when representing the time passed since the Unix epoch.
As someone who is pretty fanatical about correct time representation and testing, I wondered whether you would consider switching to Nodatime. This would give you a type (Instant) that represents the time in UTC and therefore devoid of any timezone information as well as a clock representation that can be either mocked or have a fake representation injected that allows the manipulation of time during tests.
If this would be something you'd consider, I'm happy to put a proof of concept/PR together.
Thanks for the good work, it is really a time saver.
Sean.
The text was updated successfully, but these errors were encountered: