Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangres does something to the root logger that now everything identifies as pangres #20

Closed
KIC opened this issue Oct 10, 2020 · 2 comments · Fixed by #21
Closed

Pangres does something to the root logger that now everything identifies as pangres #20

KIC opened this issue Oct 10, 2020 · 2 comments · Fixed by #21

Comments

@KIC
Copy link

KIC commented Oct 10, 2020

as soon you add pangres as your dependency suddenly all log messages identify themself as "pangres"

i.e. a log message from a custom module not looks like this:

2020-10-10 10:10:14 | INFO     | pangres     | index_utils:get_pandas_object:123 - passed item was None

I would actually expect that my applications logging settings do not change

@KIC KIC changed the title Pangres does soemthing to the root logger that now everything identifies as pangres Pangres does something to the root logger that now everything identifies as pangres Oct 10, 2020
@ThibTrip
Copy link
Owner

Hello @KIC ! Yes that is awful sorry about that 😿. This is related to the issue #18 and should be fixed by my new PR (see #21).
In addition to the screenshot I posted in issue #18 I also tested your particular problem interactively:

Before PR #21

image

After PR #21

image

I will now merge the PR. Feel free to reopen the issue if something still isn't as expected. I took the liberty of creating a new version. It will be out soon.

@KIC
Copy link
Author

KIC commented Oct 12, 2020

That was quick! Thank you very much version 2.2.1 solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants