Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing usage of https://github.com/hashicorp/go-multierror #447

Open
elordis opened this issue Jun 3, 2024 · 0 comments
Open

Comments

@elordis
Copy link

elordis commented Jun 3, 2024

@roblaszczak, @m110
Hello, team.
Our security guys recently noticed that Watermill uses https://github.com/hashicorp/go-multierror package, which uses MPL-2.0 License, which is a bit of a pain for us. After a quick look at the watermill code I've noticed that it would be trivial to replace go-multierror usage with standard library implementation. The only downside that I see is that errors.Join appeared in Go 1.20, but current Watermill is already at 1.21 and I didn't notice any version compatibility guarantees in documentation.

Are there any plans for such a change? Are you willing to accept a Pull request if we do it ourselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant