Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recreateOriginal clean up bits from Timimi #308

Open
2 tasks
YakovL opened this issue Feb 15, 2024 · 2 comments
Open
2 tasks

Make recreateOriginal clean up bits from Timimi #308

YakovL opened this issue Feb 15, 2024 · 2 comments

Comments

@YakovL
Copy link
Contributor

YakovL commented Feb 15, 2024

Inception: ibnishak/Timimi#27

Presumable solution: recreateOriginal should find div#tiddlyfox-message-box and script[src=patch-classic-io.js] (may be multiple ones) and remove them. The details of how to and whether this will work are to be figured yet.

Note: the patch-classic-io.js script is expected to be removed from the head already, so may be this should be fixed on the Timimi side instead.

  • check if removing the script via script.remove gives the desirable effect (if yes, debug Timimi; otherwise, try other methods or remove on TW side)
  • remove div#tiddlyfox-message-box anyway (TiddlyFox is probably affected as well)
@PengjuYan
Copy link
Contributor

Thank you @YakovL for creating this issue!

Hope someday I become an TWC expert and join you guys.

@YakovL
Copy link
Contributor Author

YakovL commented Feb 16, 2024

Thanks, Pengju. Ask questions if you'd like to dive into TW dev, either plugins or the core (the Google Group is probably the best place for that for now, but if there's enough interest, I'll consider opening discussions inside this Github repo).

There are also old dev docs, and I've even created some articles about git and Github there, but they are in fact in terrible condition, with tons of outdated articles, but most importantly they lack many useful ones and clarity/consistency. Updating them will require a plan and some approach that allows making one step at a time and is rewarding, instead of getting buried under an avalanche of "debt edits".

Presumably, the Dev.Plugins tiddler seems to be the place to start from (something like "Your first plugin" thing). Asking simple questions will help. If you'd like to propose edits, you can use github (currently, the html file is the source of truth, unlike for the main site).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants